Adding tt entails#12903
Adding tt entails#12903mahidhiman12 wants to merge 8 commits intoTheAlgorithms:masterfrom mahidhiman12:adding-tt-entails
Conversation
algorithms-keeper
Bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| ast.Not: operator.not_ | ||
| } | ||
|
|
||
| def safe_eval(expr: str, model: dict[str, bool]) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ttentails.py, please provide doctest for the function safe_eval
| """Safely evaluate propositional logic expression using ast.""" | ||
| tree = ast.parse(expr, mode="eval") | ||
|
|
||
| def _eval(node): |
There was a problem hiding this comment.
Please provide return type hint for the function: _eval. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file machine_learning/ttentails.py, please provide doctest for the function _eval
Please provide type hint for the parameter: node
|
|
||
| return _eval(tree) | ||
|
|
||
| def tt_entails(kb: list[str], query: str, symbols: list[str]) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/ttentails.py, please provide doctest for the function tt_entails
for more information, see https://pre-commit.ci
1 participant
Describe your change:
Checklist: